Extract large route namespace blocks to separate files #23914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
6 times, most recently
from
9b801db to
860b109
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
860b109 to
4734f72
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
3 times, most recently
from
83ac132 to
64647ca
Compare
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
64647ca to
b06d39a
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
b06d39a to
219a988
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
219a988 to
57c16ce
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
57c16ce to
7ef576b
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
4 times, most recently
from
6f3d011 to
88f6841
Compare
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
2 times, most recently
from
f4ab014 to
74b2ab3
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
74b2ab3 to
6d65147
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
2 times, most recently
from
8c47b67 to
a630485
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Uses the rails `draw` method to move the three namespaces from the routes file which were over 50 LOC into their own separate files. Includes: - API (~275 LOC) - Admin (~200 LOC) - Settings (~60 LOC) The route generation should remain exactly the same since all the `draw` usage is in the exact spot the routes were pulled out from in the main routes.rb file.
mjankowski
force-pushed
the
routes-draw-coverage-groups
branch
from
a630485 to
b28d04c
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
Gargron
approved these changes
May 2, 2023
michealmikeyb
pushed a commit
to michealmikeyb/mastodon
that referenced
this pull request
May 3, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the rails
drawmethod to move the three namespaces from the routes file which were over 50 LOC into their own separate files.Includes:
The route generation should remain exactly the same since all the
drawusage is in the exact spot the routes were pulled out from in the main routes.rb file.Opening as draft for discussion -- I generally dislike this method, and even the rails documentation about the feature -- https://guides.rubyonrails.org/routing.html#breaking-up-very-large-route-file-into-multiple-small-ones -- strongly disourages use in all except the largest routes files ... but I think this one might quality, hence the PR.
I tried to poke around previous PRs and discussion on github and couldn't find discussion on this approach specifically ... so apologies if there is something I missed there.