Skip to content

Fix mispelled spec filenames #23834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix mispelled spec filenames #23834

merged 1 commit into from
Feb 23, 2023

Conversation

nschonni
Copy link
Contributor

Was looking at RSpec/FilePath, and there were still some outstanding issues with fully PRing that one yet, so I split out the simpiler ones were there were problems with the filenames rather than just a camelCase difference

ClearlyClaire
ClearlyClaire approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of making changes that do not fix an actual issue, but git is reasonably good at handling renames. Plus one of those changes does fix something: spec/controllers/admin/users/roles_controller.rb would not run because of not ending with _spec.rb.

@ClearlyClaire ClearlyClaire merged commit 6bd7003 into mastodon:main Feb 23, 2023
@nschonni nschonni deleted the typo-files branch February 23, 2023 14:09
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
@nschonni @skerit
Fix mispelled spec filenames (mastodon#23834)
a62c278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschonni @ClearlyClaire