Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump devise from 4.8.1 to 4.9.0 #23691

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 18, 2023

Bumps devise from 4.8.1 to 4.9.0.

Release notes

Sourced from devise's releases.

v4.9.0

https://github.com/heartcombo/devise/blob/v4.9.0/CHANGELOG.md#490---2023-02-17

Changelog

Sourced from devise's changelog.

4.9.0 - 2023-02-17

  • enhancements
    • Add support for Ruby 3.1/3.2.
    • Add support for Hotwire + Turbo, default in Rails 7+.
      • Devise uses the latest responders version (v3.1.0 or higher), which allows configuring the status used for validation error responses (error_status) and for redirects after POST/PUT/PATCH/DELETE requests (redirect_status). For backwards compatibility, Devise keeps error_status as :ok which returns a 200 OK response, and redirect_status to :found which returns a 302 Found response, but you can configure it to return 422 Unprocessable Entity and 303 See Other respectively, to match the behavior expected by Hotwire/Turbo:

        # config/initializers/devise.rb
        Devise.setup do |config|
          # ...
          config.responder.error_status = :unprocessable_entity
          config.responder.redirect_status = :see_other
          # ...
        end

        These configs are already generated by default with new apps, and existing apps may opt-in as described above. Trying to set these with an older version of responders will issue a warning and have no effect, so please upgrade the responders version if you're upgrading Devise for this integration. Note that these defaults may change in future versions of Devise, to better match the Rails + Hotwire/Turbo defaults across the board.

      • If you have a custom responder set on your application and expect it to affect Devise as well, you may need to override the Devise responder entirely with config.responder = MyApplicationResponder, so that it uses your custom one. The main reason Devise uses a custom responder is to be able to configure the statuses as described above, but you can also change that config on your own responder if you want. Check the responders readme for more info on that.

      • If you have created a custom responder and/or failure app just to customize responses for better Hotwire/Turbo integration, they should no longer be necessary.

      • :turbo_stream is now treated as a navigational format, so it works like HTML navigation when using Turbo. Note: if you relied on :turbo_stream to be treated as a non-navigational format before, you can reconfigure your navigational_formats in the Devise initializer file to exclude it.

      • OmniAuth "Sign in with" links were changed to buttons that generate HTML forms with method=POST, instead of using link + method=POST that required rails-ujs to work. Since rails-ujs is no longer the default for new Rails apps, this allows the OmniAuth buttons to work in any scenario, with or without rails-ujs and/or Turbo. This only affects apps that are using the default devise/shared/_links.html.erb partial from Devise with OmniAuth enabled.

      • The "Cancel my account" button was changed to include the data-turbo-confirm option, so that it works with both rails-ujs and Turbo by default.

      • Devise does not provide "sign out" links/buttons in its shared views, but if you're using sign_out_via with :delete (the default), and are using links with method: :delete, those need to be updated with data: { turbo_method: :delete } instead for Turbo.

      • Check this upgrade guide for more detailed information.

Commits
  • 7f419bf Release Devise v4.9.0
  • 44f0fd7 Update copyright year [ci skip]
  • 2d655ea Merge pull request #5554 from JunichiIto/fix-unhappy-markup
  • 49ed129 Replce p tag with div since p tags cannot contain other block elements
  • 8e2e3f6 Merge pull request #5548 from heartcombo/ca-turbo
  • 31c4f31 Tweak comment about overriding Devise.responder
  • 8606e1e Expand changelog/readme with info about Turbo vs rails-ujs behavior
  • 2df5efc Add post install message pointing to the changelog and new upgrade guide
  • 43c349a Point version to v4.9.0.alpha for now
  • 0d392fa Use the released version of responders v3.1.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [devise](https://github.com/heartcombo/devise) from 4.8.1 to 4.9.0.
- [Release notes](https://github.com/heartcombo/devise/releases)
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md)
- [Commits](heartcombo/devise@v4.8.1...v4.9.0)

---
updated-dependencies:
- dependency-name: devise
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Feb 18, 2023
@ClearlyClaire
Copy link
Contributor

At first glance it shouldn't break anything, but it also doesn't bring anything of immediate value to us, so there's no rush and we should do some testing before merging this.

@ClearlyClaire ClearlyClaire merged commit 4b964fa into main Feb 21, 2023
@ClearlyClaire ClearlyClaire deleted the dependabot/bundler/devise-4.9.0 branch February 21, 2023 09:41
Lamparter added a commit to RiversideValley/Plaza that referenced this pull request Feb 21, 2023
* Autofix Rubocop Style/EmptyMethod (mastodon#23732)

* Autofix Rubocop Rails/RedundantForeignKey (mastodon#23731)

* Autofix Rubocop Rails/Pluck (mastodon#23730)

* Autofix Rubocop RSpec/ReturnFromStub (mastodon#23724)

* Enable Rubocop RSpec/NotToNot (mastodon#23723)

* Autofix Rubocop Lint/UnusedBlockArgument (mastodon#23712)

* Autofix Rubocop RSpec/EmptyLineAfterSubject (mastodon#23719)

* Enable Rubocop HTTP status rules (mastodon#23717)

* Autofix Rubocops RSpec/ScatteredLet (mastodon#23725)

* Autofix Rubocop Style/ExplicitBlockArgument (mastodon#23704)

* Rename JSX files with proper `.jsx` extension (mastodon#23733)

* Autofix Rubocop Rails/EnumHash (mastodon#23737)

* Autofix Rubocop RSpec/ImplicitSubject (mastodon#23721)

* Enable Rubocop RSpec/ExpectActual (mastodon#23720)

* Autofix Rubocop RSpec/LeadingSubject (mastodon#23670)

* Audofix Rubocop Style/WordArray (mastodon#23739)

* Autofix Rubocop RSpec/BeEq (mastodon#23740)

* Autofix Rubocop Style/UnpackFirst (mastodon#23741)

* Autofix Rubocop remaining Layout rules (mastodon#23679)

* Fix Markdown files with Prettier and check in CI (mastodon#21972)

* Autofix Rubocop Style/FormatString (mastodon#23743)

* Autofix Rubocop Style/SymbolProc (mastodon#23742)

* Make larger part of status clickable (mastodon#23621)

* Autofix Rubocop Style/RescueStandardError (mastodon#23745)

* Update rebase needed job settings (mastodon#23746)

* Change compose form checkbox to native input with `appearance: none` (mastodon#22949)

* Autofix Rubocop Rails/WhereEquals (mastodon#23759)

* Autofix Rubocop Security/IoMethods (mastodon#23757)

* Autofix Rubocop Rails/FindById (mastodon#23762)

* Add `lang` tag to native language names in language picker (mastodon#23749)

* Bump capistrano from 3.17.1 to 3.17.2 (mastodon#23775)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sass from 1.58.2 to 1.58.3 (mastodon#23772)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump blurhash from 2.0.4 to 2.0.5 (mastodon#23771)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump stylelint from 15.1.0 to 15.2.0 (mastodon#23770)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix sidebar cut-off on small screens in admin UI (mastodon#23764)

* Bump devise from 4.8.1 to 4.9.0 (mastodon#23691)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/runtime from 7.20.13 to 7.21.0 (mastodon#23773)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/core from 7.20.12 to 7.21.0 (mastodon#23767)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/plugin-transform-runtime from 7.19.6 to 7.21.0 (mastodon#23774)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/plugin-transform-react-inline-elements from 7.18.6 to 7.21.0 (mastodon#23766)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/plugin-proposal-decorators from 7.20.13 to 7.21.0 (mastodon#23769)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Delete CHANGELOG.md

* Delete CONTRIBUTING.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Renaud Chaput <[email protected]>
Co-authored-by: Christian Schmidt <[email protected]>
Co-authored-by: Claire <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Botao Wang <[email protected]>
btrd pushed a commit to btrd/mastodon that referenced this pull request Feb 22, 2023
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant