Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest redis-rb 4.x and fix deprecations #23616

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Upgrade to latest redis-rb 4.x and fix deprecations #23616

merged 1 commit into from
Mar 4, 2023

Conversation

casperisfine
Copy link
Contributor

Ref: #23516

This will make it easier to migrate to redis-rb 5.x.

cc @Gargron

@casperisfine casperisfine force-pushed the redis-deprecations branch 2 times, most recently from 916d1a5 to 29e9078 Compare February 15, 2023 11:53
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@casperisfine casperisfine requested a review from Gargron February 20, 2023 08:53
ClearlyClaire
ClearlyClaire reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be split between fixing deprecations and actually upgrading redis-rb. There is a small style issue, but otherwise it looks good to me.

app/lib/feed_manager.rb Outdated Show resolved Hide resolved
@casperisfine casperisfine force-pushed the redis-deprecations branch 2 times, most recently from 02a617c to c90750d Compare February 21, 2023 15:51
@casperisfine
Copy link
Contributor Author

I just pushed another commit to fix the two Redis.current calls in old migrations.

Gargron
Gargron requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Gargron Gargron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined method `connection' for RedisConfiguration:Class

db/migrate/20170920032311_fix_reblogs_in_feeds.rb Outdated Show resolved Hide resolved
db/migrate/20200407202420_migrate_unavailable_inboxes.rb Outdated Show resolved Hide resolved
@byroot
Upgrade to latest redis-rb 4.x and fix deprecations
8450d0f 
Ref: mastodon#23516

This will make it easier to migrate to redis-rb 5.x.
@casperisfine
Copy link
Contributor Author

@Gargron thanks, I updated the PR.

@mjankowski
Copy link
Contributor

A rebase against main should fix the ruby linting CI failure.

@Gargron Gargron merged commit 922837d into mastodon:main Mar 4, 2023
@nschonni nschonni mentioned this pull request Mar 5, 2023
Closed
arachnist pushed a commit to arachnist/mastodon that referenced this pull request Apr 4, 2023
@casperisfine @byroot @arachnist
Upgrade to latest redis-rb 4.x and fix deprecations (mastodon#23616)
4e8285e 
Co-authored-by: Jean Boussier <[email protected]>
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
@casperisfine @byroot @skerit
Upgrade to latest redis-rb 4.x and fix deprecations (mastodon#23616)
ee6e236 
Co-authored-by: Jean Boussier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire left review comments

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@casperisfine @mjankowski @Gargron @ClearlyClaire @byroot