Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Node.js to 16.19 patch release #23554

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Sync Node.js to 16.19 patch release #23554

merged 1 commit into from
Feb 13, 2023

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Feb 12, 2023

Alternately, the .nvmrc could be made more specific, but then it would need to be kept in sync. The current v16 is 16.19.0, so these are already a security release behind

Since CircleCI doesn't support a floating major version, changed to the latest patch release and synced the .nvmrc so it's consistent

@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.4
# This needs to be bullseye-slim because the Ruby image is built on bullseye-slim
ARG NODE_VERSION="16.18.1-bullseye-slim"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep specific version in the Dockerfile so we can explicitly trigger update (manual or auto update) when a new version is released.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also it permits to know which version is used)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CircleCI doesn't support the floating major, I went down to the minor level. The images are already built on every push to the main branch, so I don't think there needs to be the full version here just to trigger a release. That would happen during a normal release

@nschonni nschonni changed the title Use latest Node.js 16 releases to match .nvmrc Sync Node.js to 16.19 patch release Feb 12, 2023
@Gargron Gargron merged commit c6b7e04 into mastodon:main Feb 13, 2023
@nschonni nschonni deleted the node-16 branch February 13, 2023 03:59
neatchee added a commit to neatchee/mastodon that referenced this pull request Feb 16, 2023
* dot is not allowed (mastodon#23519)

* fix metrics format (mastodon#23520)

* Bump blurhash from 0.1.6 to 0.1.7 (mastodon#23517)

* Enable EditorConfig trailing whitespace trimming (mastodon#23543)

* Upgrade to Stylelint 15 with Prettier (mastodon#23558)

* Yarn cache cleanup right after install in Docker (mastodon#23557)

* Sync Node.js to 16.19 patch release (mastodon#23554)

* Update SECURITY.md (mastodon#23545)

Co-authored-by: Eugen Rochko <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>

* Replace hamlit-rails with haml-rails (mastodon#23542)

* Add tests for `REST::AccountSerializer` (mastodon#23319)

* Bump sidekiq-scheduler from 4.0.3 to 5.0.0 (mastodon#23212)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claire <[email protected]>

* Bump sidekiq-scheduler from 5.0.0 to 5.0.1 (mastodon#23569)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add dependency on net-http (mastodon#23571)

* Bump rubocop from 1.44.1 to 1.45.1 (mastodon#23523)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Change followed_by link to location=all if account is local on /admin/accounts/:id page (mastodon#23467)

* Update Ruby to 3.0.5 (mastodon#23544)

* Fix case-sensitive check for previously used hashtags (mastodon#23526)

* Enable ESLint no-useless-escape (mastodon#23311)

* Enable ESLint import recommended rules (mastodon#23315)

* Switch OpenID Connect gems (mastodon#23223)

Co-authored-by: Claire <[email protected]>

* Add tests to indicate inclusion of self replies in statuses endpoint (mastodon#23266)

* chewy from 7.2.4 to 7.2.7 (mastodon#23572)

* Add API parameter to safeguard unexpect mentions in new posts (mastodon#18350)

* Bump aws-sdk-s3 from 1.119.0 to 1.119.1 (mastodon#23586)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump nokogiri from 1.14.1 to 1.14.2 (mastodon#23577)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump stylelint-config-standard-scss from 7.0.0 to 7.0.1 (mastodon#23578)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 8.12.0 to 8.12.1 (mastodon#23579)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump axios from 1.3.2 to 1.3.3 (mastodon#23580)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump webpack-bundle-analyzer from 4.7.0 to 4.8.0 (mastodon#23581)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prettier from 2.8.3 to 2.8.4 (mastodon#23584)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump jest from 29.4.1 to 29.4.2 (mastodon#23585)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump jest-environment-jsdom from 29.4.1 to 29.4.2 (mastodon#23582)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump babel-jest from 29.4.1 to 29.4.2 (mastodon#23583)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add `memorial` attribute to REST API (mastodon#23591)

* Fix paths with url-encoded @ to redirect to the correct path (mastodon#23593)

* Port upstream changes to glitch

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: emilweth <[email protected]>
Co-authored-by: Eugen Rochko <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Takeshi Umeda <[email protected]>
Co-authored-by: Claire <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeong Arm <[email protected]>
Co-authored-by: Dean Bassett <[email protected]>
Co-authored-by: Stan Hu <[email protected]>
Co-authored-by: Varun Sharma <[email protected]>
Co-authored-by: Shlee <[email protected]>
Co-authored-by: Thijs Kinkhorst <[email protected]>
btrd pushed a commit to btrd/mastodon that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants