Align everything to Node.js 16 #22223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re still in support/maintenance
Gargron
approved these changes
Dec 15, 2022
|
Is there a reason for requiring Node 16+ rather than staying with Node 14+? Node.js 14 isn't EOL yet and I'd prefer if we avoided causing trouble for admins unless needed. |
|
Better to cause problems now than when it's EOL, and then a security exploit gets discovered that won't get fixed as Node 14 is EOL. |
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
* Update nvmrc to Node.js 16 * Update package.json minimum Node engine to 16 * Update README requirements to Node.js 16 * Update devcontainer Node.js version to 16 * Update devcontainer Dockerfile Node.js choices to LTS versions that are still in support/maintenance * Pin CircleCI Node image to 16 * Fix YAML type issue * Update CircleCI Node.js to 16.18 to match mastodon#22019
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* Update nvmrc to Node.js 16 * Update package.json minimum Node engine to 16 * Update README requirements to Node.js 16 * Update devcontainer Node.js version to 16 * Update devcontainer Dockerfile Node.js choices to LTS versions that are still in support/maintenance * Pin CircleCI Node image to 16 * Fix YAML type issue * Update CircleCI Node.js to 16.18 to match mastodon#22019 # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 14 is goes end-of-life in 4 months, and half of the repo (Vagrantfile, Dockerfile, CircleCI) is already using newer versions.
This PR aligns everything to Node 16, including pinning CircleCI which is using "lts" and had already jumped to Node 18.