Replace from Code Climate to Super-Linter #18587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jun 1, 2022
|
Trying to merge the changes in glitch-soc, I am confused at it complaining on lines that haven't been changed from upstream. Also, its output is a lot less friendly than CodeClimate :/ |
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
untitaker
added a commit
to untitaker/mastodon
that referenced
this pull request
Jan 9, 2023
Switching to super-linter reveals too many linting errors in files I touch in PRs. It seems that the PR that did this: mastodon#18587 -- is largely frontend-motivated, and that backend was better off with codeclimate. Since both codeclimate and superlinter is configured in principle anyway, we might as well have codeclimate for the backend and superlinter for the frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Code Climate runs in a sandbox, it is incompatible with Linter (e.g. ESLint), which relies on external libraries. It also does not support stylelint, an alternative to sass-lint, which is no longer maintained.
In this Pull Request, we are replacing Code Climate with Super-Linter, which is developed by GitHub and is compatible with GitHub Pull Requests.