Fix performance of account timelines #17709
Conversation
Gargron
force-pushed
the
fix-account-statuses-query-performance
branch
from
9a750f4 to
79f7354
Compare
There was a problem hiding this comment.
The refactor is welcome, but I think I found a bug (inline comment).
Otherwise I'm on the fence about not listing DMs (or private messages, if you don't follow the person) that mention you, as there are little other places where you can check them (especially with Mastodon's DM conversation view not handling broken or forking threads very well). On the other hand, the speedup you're claiming is more than tempting.
I wonder if there's a way to improve the existing query, but I'm not sure we can efficiently handle the case where someone who often gets mentioned looks at the profile of someone they don't follow (or who sends a lot of DMs).
Gargron
force-pushed
the
fix-account-statuses-query-performance
branch
from
e0606c8 to
fa9a38f
Compare
|
No more behaviour change regarding mentions, join is faster than subquery. Fixed typo. |
Co-authored-by: Claire <[email protected]>
When
exclude_reblogs,taggedoronly_mediafilters are requested, there is no way that a reblog would turn up in the results; nevertheless, previously a join was performed even on those queries to filter out potential reblogs from excluded accounts. This made those queries unnecessarily slower.Comparison for a "Posts" tab query as a logged-in follower (same profile):
Comparison for the "Media" tab (same profile):