Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autocomplete type of password input box #17702

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

mashirozx
Copy link
Contributor

@mashirozx mashirozx commented Mar 5, 2022

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

image

Currently, if you save the Mastodon password in your browser, it will auto fill your password in registration form, this is not what we expected. Change it to new-password to disable the auto fill (autocomplete=off does not work on Chrome).

@Gargron Gargron merged commit 87a55e2 into mastodon:main Mar 5, 2022
@mashirozx mashirozx deleted the patch-1 branch March 5, 2022 04:59
@ClearlyClaire
Copy link
Contributor

ClearlyClaire commented Mar 5, 2022

How does it behave Safari? https://caniuse.com/mdn-html_global_attributes_autocomplete_new-password

Also, app/views/auth/passwords/edit.html.haml, app/views/auth/registrations/new.html.haml and app/views/auth/registrations/edit.html.haml might benefit from such a change too.

@mashirozx
Copy link
Contributor Author

Also curious about how it behaves on safari.

I'll create PR for them later, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants