Fix media modal footer's “external link” not being a link #17561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
commented
Feb 15, 2022
Comment on lines
+134
to
+140
| if (href) { | ||
| contents = ( | ||
| <a href={href} target='_blank' rel='noopener noreferrer'> | ||
| {contents} | ||
| </a> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Having a link inside a button is weird, but it's the only way I have found to have the same padding than on buttons, as for some reason, Firefox seems to put some extra padding inside buttons, that I could not influence no matter what attribute I tried overriding.
Gargron
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ctrl-clicking or middle-clicking the “external link” icon and have the expected behavior.