Helm chart SSO support #17205
Merged
Helm chart SSO support #17205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable single sign-on configuration via the Helm chart. Support for
WEB_DOMAINandS3_ALIAS_HOSTare also added here, being very simple and adjacent to the bulk of this work. LDAP, PAM, CAS, and SAML are implemented from existing support, and OpenID Connect support is included from the draft environment variables provided in PR #16221. All variables are tested to render correctly, and both SAML and WEB_DOMAIN are running in production on my instance, hellsite.net.OAUTH_REDIRECT_AT_SIGN_INis described as redirecting only CAS for now, prior to confirmation of also functioning with OIDC. This is my first pull request, ever, so please excuse and correct any oversights. Thank you all for your hard work on this excellent software!