Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for new sign-ups #16953

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 7, 2021

Fix #16229

New notification type: admin.sign_up


This project was funded through the NGI0 Discovery Fund, a fund established by NLnet with financial support from the European Commission's Next Generation Internet programme, under the aegis of DG Communications Networks, Content and Technology under grant agreement No 825322.

@Gargron Gargron added the moderation Administration and moderation tooling label Nov 7, 2021
@shleeable
Copy link
Contributor

👀

@Gargron Gargron force-pushed the feature-admin-notifications branch from 7992058 to 86486e8 Compare February 22, 2022 03:42
@Gargron Gargron changed the title Add notifications for administrative events Add notifications for new sign-ups Feb 22, 2022
@Gargron Gargron marked this pull request as ready for review February 22, 2022 03:42
@Gargron Gargron force-pushed the feature-admin-notifications branch 4 times, most recently from b765256 to 1488f10 Compare February 22, 2022 03:53
@Gargron Gargron force-pushed the feature-admin-notifications branch from 1488f10 to 12c92b2 Compare February 22, 2022 05:20
@@ -45,7 +45,7 @@ defineMessages({
});

const fetchRelatedRelationships = (dispatch, notifications) => {
const accountIds = notifications.filter(item => item.type === 'follow').map(item => item.account.id);
const accountIds = notifications.filter(item => ['follow', 'follow_request', 'admin.sign_up'].indexOf(item.type) !== -1).map(item => item.account.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['follow', 'follow_request', 'admin.sign_up'].includes(item.type)?

@Gargron Gargron merged commit 7b816eb into main Feb 23, 2022
@Gargron Gargron deleted the feature-admin-notifications branch February 23, 2022 15:45
@Gargron Gargron added api REST API, Streaming API, Web Push API NLnet Funded by NLnet, see https://nlnet.nl/project/Mastodon/ labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API moderation Administration and moderation tooling NLnet Funded by NLnet, see https://nlnet.nl/project/Mastodon/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 3.4: Default follows for new users
3 participants