Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS 14 support - circleci/docker/.nvmrc #16163

Merged
merged 11 commits into from
Aug 10, 2021
Merged

NodeJS 14 support - circleci/docker/.nvmrc #16163

merged 11 commits into from
Aug 10, 2021

Conversation

shleeable
Copy link
Contributor

@shleeable shleeable commented May 6, 2021

NodeJS v14 is now the LTS release.

@shleeable shleeable changed the title circleci - node14 test NodeJS 14 support - circleci/docker/.nvmrc May 6, 2021
@shleeable shleeable marked this pull request as ready for review May 6, 2021 13:41
@shleeable
Copy link
Contributor Author

@Gargron Hey, I've been running v3.4.0 on NodeJS 14.17.

No problems so far

@danieljakots
Copy link
Contributor

Any reason why this wasn't merged yet?

@shleeable
Copy link
Contributor Author

Tested for the last week. No issues I'm aware of.

@shleeable
Copy link
Contributor Author

@weex
Copy link
Contributor

weex commented Aug 5, 2021

I noticed the README lists Node.js 12+ in requirements which this should also update.

@Gargron Gargron merged commit 229f5d1 into mastodon:main Aug 10, 2021
weex referenced this pull request in magicstone-dev/ecko Aug 10, 2021
Revert "NodeJS 14 support - circleci/docker/.nvmrc (#16163)"
@shleeable shleeable deleted the patch-1 branch August 10, 2021 23:10
chasedream1129 pushed a commit to monado-ren/mastodon that referenced this pull request Aug 12, 2021
* Update config.yml

* Update Dockerfile

* Update .nvmrc

* Update Dockerfile

* NodeJS 10 is EOL.

* Update package.json

* Update README.md

* Update Vagrantfile

* Update Dockerfile

* Update Dockerfile
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
* Update config.yml

* Update Dockerfile

* Update .nvmrc

* Update Dockerfile

* NodeJS 10 is EOL.

* Update package.json

* Update README.md

* Update Vagrantfile

* Update Dockerfile

* Update Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants