Change auto-following admin-selected accounts, show in recommendations #16078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-change-autofollow
branch
3 times, most recently
from
009e151 to
6169d8e
Compare
|
Note: CI fails because other translations have not been updated with the new variable in the setting description. |
ykzts
approved these changes
Apr 20, 2021
ClearlyClaire
requested changes
Apr 20, 2021
Comment on lines
+7
to
+25
| usernames_and_domains = begin | ||
| value.split(',').map do |str| | ||
| username, domain = str.strip.gsub(/\A@/, '').split('@') | ||
| domain = nil if TagManager.instance.local_domain?(domain) | ||
|
|
||
| next if username.blank? | ||
|
|
||
| [str, username, domain] | ||
| end.compact | ||
| end | ||
|
|
||
| usernames_with_no_accounts = usernames_and_domains.filter_map do |(str, username, domain)| | ||
| str unless Account.find_remote(username, domain) | ||
| end | ||
|
|
||
| if usernames_with_no_accounts.any? && options[:multiple] | ||
| record.errors.add(attribute, I18n.t('existing_username_validator.not_found_multiple', usernames: usernames_with_no_accounts.join(', '))) | ||
| elsif usernames_with_no_accounts.any? || usernames_and_domains.size > 1 | ||
| record.errors.add(attribute, I18n.t('existing_username_validator.not_found')) |
There was a problem hiding this comment.
This changes the scope of this validator from local accounts only to any known account, which kind of makes sense for recommendations but less so for site_contact_username which also uses this validator.
There was a problem hiding this comment.
Counter-point: On mastodon.online, I might as well just point to my mastodon.social account in that field
Not sure if there's any true benefit to enforcing locality in this validator.
Gargron
force-pushed
the
fix-change-autofollow
branch
from
6169d8e to
0fa49f3
Compare
Gargron
force-pushed
the
fix-change-autofollow
branch
from
0fa49f3 to
90c5b84
Compare
ClearlyClaire
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making new users automatically follow accounts specified in admin settings, show them at the top of follow recommendations. Also, allow picking remote accounts instead of limiting them to local only.
The "Enable default follows for new users" setting has been removed. "Default follows for new users" has been renamed to "Recommend these accounts to new users", and it no longer defaults to all admin accounts.