replace all instances of "ends_with?" with "end_with?" #15745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ends_with?" method is just a Rails alias of Ruby's "end_with?" method. Using the latter makes the code less brittle.
ClearlyClaire
approved these changes
Feb 17, 2021
dr-bonez
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Mar 1, 2021
The "ends_with?" method is just a Rails alias of Ruby's "end_with?" method. Using the latter makes the code less brittle.
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
The "ends_with?" method is just a Rails alias of Ruby's "end_with?" method. Using the latter makes the code less brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ends_with?method is just a Rails alias of Ruby'send_with?method. Using the latter makes the code less brittle.This is a follow up to #15741 (and #15739), since I don't think the Rack monkey patch should work with
ends_with?? I haven't tested this PR either, but it should be pretty safe, given the above links.Edit to add: To be clear, I have tested that
ends_with?andend_with?do the same thing in the rails app and tests I have lying around, I just haven't tested Mastodon specifically.