Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.7.0 to 1.8.1 #15573

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Bump rubocop from 1.7.0 to 1.8.1 #15573

merged 2 commits into from
Jan 31, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 18, 2021

Bumps rubocop from 1.7.0 to 1.8.1.

Release notes

Sourced from rubocop's releases.

v1.8.1

Bug fixes

  • #9342: Fix an error for Lint/RedundantDirGlobSort when using collection.sort. (@koic)
  • #9304: Do not register an offense for Style/ExplicitBlockArgument when the yield arguments are not an exact match with the block arguments. (@dvandersluis)
  • #8281: Fix Style/WhileUntilModifier handling comments and assignment when correcting to modifier form. (@Darhazer)
  • #8229: Fix faulty calculation in UncommunicativeName. (@ohbarye)
  • #9350: Wrap in parens before replacing unless with if and !. (@magneland)
  • #9356: Fix duplicate extension cop versions when using rubocop -V. (@koic)
  • #9355: Fix Style/SingleLineMethods autocorrection to endless method when the original code had parens. (@dvandersluis)
  • #9346: Fix an incorrect auto-correct for Style/StringConcatenation when concat string include double quotes and interpolation. (@k-karen)

RuboCop 1.8

New features

Bug fixes

  • #9298: Fix an incorrect auto-correct for Lint/RedundantCopDisableDirective when there is a blank line before inline comment. (@koic)
  • #9233: Fix Style/SoleNestedConditional copying non-relevant comments during auto-correction. (@Darhazer)
  • #9312: Fix Layout/FirstHashElementLineBreak to apply to multi-line hashes with only a single element. ([@muirdm][])
  • #9316: Fix Style/EmptyLiteral registering wrong offense when using a numbered block for Hash.new, i.e. Hash.new { _1[_2] = [] }. ([@agargiulo][])
  • #9308: Fix an error for Layout/EmptyLineBetweenDefs when using endless class method. (@koic)
  • #9314: Fix an incorrect auto-correct for Style/RedundantReturn when multiple return values have a parenthesized return value. (@koic)
  • #9335: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with Style/NestedParenthesizedCalls. (@koic)
  • #9290: Fix a false positive for Layout/SpaceBeforeBrackets when using array literal method argument. (@koic)
  • #9333: Fix an error for Style/IfInsideElse when using a modifier if nested inside an else after elsif. (@koic)
  • #9303: Fix an incorrect auto-correct for Style/RaiseArgs with EnforcedStyle: compact when using exception instantiation argument. (@koic)

Changes

  • #9300: Make Lint/NonDeterministicRequireOrder not to register offense when using Ruby 3.0 or higher. (@koic)
  • #9320: Support unicode-display_width v2. ([@dduugg][])
  • #9288: Require Parser 3.0.0.0 or higher. (@koic)
  • #9337: Add AllowedIdentifiers to Naming/VariableName. (@dvandersluis)
  • #9295: Update Style/SingleLineMethods to correct to an endless method definition if they are allowed. (@dvandersluis)
  • #9331: Mark Style/MutableConstant as unsafe. (@koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.8.1 (2021-01-11)

Bug fixes

  • #9342: Fix an error for Lint/RedundantDirGlobSort when using collection.sort. ([@koic][])
  • #9304: Do not register an offense for Style/ExplicitBlockArgument when the yield arguments are not an exact match with the block arguments. ([@dvandersluis][])
  • #8281: Fix Style/WhileUntilModifier handling comments and assignment when correcting to modifier form. ([@Darhazer][])
  • #8229: Fix faulty calculation in UncommunicativeName. ([@ohbarye][])
  • #9350: Wrap in parens before replacing unless with if and !. ([@magneland][])
  • #9356: Fix duplicate extension cop versions when using rubocop -V. ([@koic][])
  • #9355: Fix Style/SingleLineMethods autocorrection to endless method when the original code had parens. ([@dvandersluis][])
  • #9346: Fix an incorrect auto-correct for Style/StringConcatenation when concat string include double quotes and interpolation. ([@k-karen][])

1.8.0 (2021-01-07)

New features

Bug fixes

  • #9298: Fix an incorrect auto-correct for Lint/RedundantCopDisableDirective when there is a blank line before inline comment. ([@koic][])
  • #9233: Fix Style/SoleNestedConditional copying non-relevant comments during auto-correction. ([@Darhazer][])
  • #9312: Fix Layout/FirstHashElementLineBreak to apply to multi-line hashes with only a single element. ([@muirdm][])
  • #9316: Fix Style/EmptyLiteral registering wrong offense when using a numbered block for Hash.new, i.e. Hash.new { _1[_2] = [] }. ([@agargiulo][])
  • #9308: Fix an error for Layout/EmptyLineBetweenDefs when using endless class method. ([@koic][])
  • #9314: Fix an incorrect auto-correct for Style/RedundantReturn when multiple return values have a parenthesized return value. ([@koic][])
  • #9335: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with Style/NestedParenthesizedCalls. ([@koic][])
  • #9290: Fix a false positive for Layout/SpaceBeforeBrackets when using array literal method argument. ([@koic][])
  • #9333: Fix an error for Style/IfInsideElse when using a modifier if nested inside an else after elsif. ([@koic][])
  • #9303: Fix an incorrect auto-correct for Style/RaiseArgs with EnforcedStyle: compact when using exception instantiation argument. ([@koic][])

Changes

  • #9300: Make Lint/NonDeterministicRequireOrder not to register offense when using Ruby 3.0 or higher. ([@koic][])
  • #9320: Support unicode-display_width v2. ([@dduugg][])
  • #9288: Require Parser 3.0.0.0 or higher. ([@koic][])
  • #9337: Add AllowedIdentifiers to Naming/VariableName. ([@dvandersluis][])
  • #9295: Update Style/SingleLineMethods to correct to an endless method definition if they are allowed. ([@dvandersluis][])
  • #9331: Mark Style/MutableConstant as unsafe. ([@koic][])
Commits
  • b9cd27a Cut 1.8.1
  • 9240568 Update Changelog
  • 946d5c3 Fix bug not escape double quotes.
  • d2c2529 [Fix #8281] Improve WhileUntilModifier detection and correction
  • dd54974 [Fix #9304] Do not register an offense for Style/ExplicitBlockArgument when...
  • cbe439b Merge pull request #9360 from dvandersluis/allow-pry
  • 94ced7b Merge pull request #9361 from dvandersluis/issue/9355
  • 7f09c74 Add @dvandersluis to the Core Team
  • f588088 [Fix #9355] Fix Style/SingleLineMethods autocorrection to endless method wh...
  • f801209 Allow pry to be activated in rspec if in the local gemfile.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 18, 2021
@dependabot dependabot bot changed the base branch from master to main January 20, 2021 10:31
An error occurred while trying to automatically change base from master to main January 20, 2021 10:31
@ykzts ykzts force-pushed the dependabot/bundler/rubocop-1.8.1 branch from 76bde30 to 012f141 Compare January 31, 2021 18:19
@ykzts ykzts merged commit eb0f9e3 into main Jan 31, 2021
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.8.1 branch January 31, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant