Fix to isolate the sidekiq process that runs the scheduler job #15314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noellabo
force-pushed
the
fix-to-isolate-process-that-runs-the-scheduler-job
branch
from
36696c1 to
b37b3a0
Compare
|
With this change I believe locks can be taken out of the scheduler classes |
Gargron
approved these changes
Dec 15, 2020
|
Just upgrading to 3.3.0 from 3.1.3 and I noticed the new queue. How do you see this working if running multiple instances in containers (k8s cluster)? Running multiple instances of the streaming api, web and sidekiq processes for resilience and performance takes a hit here, as we need a single dedicated instance for the scheduler. Any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14764
Introduce a scheduler queue that runs the scheduler job so that only the sidekiq process that processes this queue runs the schedule.
In the case of a single sidekiq process, everything is processed, including the schedule, as before.
If you have multiple sidekiq processes running, only the process that handles the scheduler queue handles the schedule.
For existing configurations with multiple sidekiq processes running explicitly in the queue, this change prevents scheduled execution because there is no process to handle the scheduler queue.
The solution is to have one of the processes process the scheduler queue, or add a dedicated process for scheduled execution.