Display “Show newer” and “Show older” instead of “Show more” in public pages #15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Oct 27, 2020
Gargron
reviewed
Oct 27, 2020
| @@ -17,7 +17,7 @@ | |||
| - if status.reply? && include_threads | |||
| - if @next_ancestor | |||
| .entry{ class: entry_classes } | |||
| = link_to_more ActivityPub::TagManager.instance.url_for(@next_ancestor) | |||
| = link_to_older ActivityPub::TagManager.instance.url_for(@next_ancestor) | |||
There was a problem hiding this comment.
Hm, in case of threads, I am not sure if older/newer makes more sense than just "more". It's true that descendants are "newer" and ancestors are "older", but it may still be confusing. I'm not sure. Would love to hear what others think.
There was a problem hiding this comment.
I think it's good either way, though showing just “more” would require yet another translatable string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows for better translations (it was limiting me in French) and it makes clearer what the “order” of the toots is.
On a profile page:
On a thread page:
