Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.86.0 to 0.88.0 #14412

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 27, 2020

Bumps rubocop from 0.86.0 to 0.88.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.88

New features

Bug fixes

  • #8232: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when end immediately after access modifier. (@koic)
  • #7777: Fix crash for Layout/MultilineArrayBraceLayout when comment is present after last element. (@shekhar-patil)
  • #7776: Fix crash for Layout/MultilineMethodCallBraceLayout when comment is present before closing braces. (@shekhar-patil)
  • #8282: Fix Style/IfUnlessModifier bad precedence detection. (@tejasbubane)
  • #8289: Fix Style/AccessorGrouping to not register offense for accessor with comment. (@tejasbubane)
  • #8310: Handle major version requirements in Gemspec/RequiredRubyVersion. (@eugeneius)
  • #8315: Fix crash for Style/PercentLiteralDelimiters when the source contains invalid characters. (@eugeneius)
  • #8239: Don't load .rubocop.yml files at all outside of the current project, unless they are personal configuration files and the project has no configuration. (@deivid-rodriguez)

Changes

  • #8021: Rewrite Layout/SpaceAroundMethodCallOperator cop to make it faster. (@fatkodima)
  • #8294: Add of to AllowedNames of MethodParameterName cop. (@AlexWayfer)

RuboCop 0.87.1

Bug fixes

  • #8252: Fix a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.86 and lower. (@koic)
  • #8259: Fix false positives for Style/BisectedAttrAccessor when accessors have different access modifiers. (@fatkodima)
  • #8253: Fix false positives for Style/AccessorGrouping when accessors have different access modifiers. (@fatkodima)
  • #8257: Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments. (@fatkodima)
  • #8239: Don't load .rubocop.yml from personal folders to check for exclusions if given a custom configuration file. (@deivid-rodriguez)
  • #8256: Fix an error for --auto-gen-config when running a cop who do not support auto-correction. (@koic)
  • #8262: Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use lower case, as some Linux-based systems do not accept upper cased cipher names. ([@bdewater][])
Changelog

Sourced from rubocop's changelog.

0.88.0 (2020-07-13)

New features

  • #8279: Recognise require method passed as argument in Lint/NonDeterministicRequireOrder cop. ([@biinari][])
  • #7333: Add new Style/RedundantFileExtensionInRequire cop. ([@fatkodima][])
  • #8316: Support autocorrect for Lint/DisjunctiveAssignmentInConstructor cop. ([@fatkodima][])
  • #8242: Internal profiling available with bin/rubocop-profile and rake tasks. ([@marcandre][])
  • #8295: Add new Style/ArrayCoercion cop. ([@fatkodima][])
  • #8293: Add new Lint/DuplicateElsifCondition cop. ([@fatkodima][])
  • #7736: Add new Style/CaseLikeIf cop. ([@fatkodima][])
  • #4286: Add new Style/HashAsLastArrayItem cop. ([@fatkodima][])
  • #8247: Add new Style/HashLikeCase cop. ([@fatkodima][])
  • #8286: Internal method expect_offense allows abbreviated offense messages. ([@marcandre][])

Bug fixes

  • #8232: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when end immediately after access modifier. ([@koic][])
  • #7777: Fix crash for Layout/MultilineArrayBraceLayout when comment is present after last element. ([@shekhar-patil][])
  • #7776: Fix crash for Layout/MultilineMethodCallBraceLayout when comment is present before closing braces. ([@shekhar-patil][])
  • #8282: Fix Style/IfUnlessModifier bad precedence detection. ([@tejasbubane][])
  • #8289: Fix Style/AccessorGrouping to not register offense for accessor with comment. ([@tejasbubane][])
  • #8310: Handle major version requirements in Gemspec/RequiredRubyVersion. ([@eugeneius][])
  • #8315: Fix crash for Style/PercentLiteralDelimiters when the source contains invalid characters. ([@eugeneius][])
  • #8239: Don't load .rubocop.yml files at all outside of the current project, unless they are personal configuration files and the project has no configuration. ([@deivid-rodriguez][])

Changes

  • #8021: Rewrite Layout/SpaceAroundMethodCallOperator cop to make it faster. ([@fatkodima][])
  • #8294: Add of to AllowedNames of MethodParameterName cop. ([@AlexWayfer][])

0.87.1 (2020-07-07)

Bug fixes

  • #8189: Fix an error for Layout/MultilineBlockLayout where spaces for a new line where not considered. ([@knejad][])
  • #8252: Fix a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.86 and lower. ([@koic][])
  • #8259: Fix false positives for Style/BisectedAttrAccessor when accessors have different access modifiers. ([@fatkodima][])
  • #8253: Fix false positives for Style/AccessorGrouping when accessors have different access modifiers. ([@fatkodima][])
  • #8257: Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments. ([@fatkodima][])
  • #8239: Don't load .rubocop.yml from personal folders to check for exclusions if given a custom configuration file. ([@deivid-rodriguez][])
  • #8256: Fix an error for --auto-gen-config when running a cop who do not support auto-correction. ([@koic][])
  • #8262: Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use lower case, as some Linux-based systems do not accept upper cased cipher names. ([@bdewater][])

0.87.0 (2020-07-06)

New features

Commits
  • acddd73 Cut 0.88
  • 535c544 Add a changelog entry
  • d1822bc Ignore configuration files outside of the project
  • e1a2da0 Only look up to the project's root for exclusions
  • 0563861 Fix traverse_files_upwards to make searching up to the root possible
  • 18e318f Merge pull request #8279 from Fatsoma/feature/require_order_block_pass
  • fe066fc Merge branch 'master' into feature/require_order_block_pass
  • 0c786c0 Fix line number for empty file offense
  • 930b65f Fix expect_offense when annotations missing
  • 34a2dbd Merge pull request #8316 from fatkodima/autocorrect-to-disjunctive_assignment...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 27, 2020
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-0.88.0 branch from bbeb9ff to 98fcf93 Compare July 27, 2020 18:32
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-0.88.0 branch from 98fcf93 to cfb2164 Compare July 28, 2020 15:55
@ykzts ykzts requested a review from Gargron July 28, 2020 19:37
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 10, 2020

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@@ -13,7 +13,9 @@ def call(recipient, activity)
push_to_conversation! if direct_message?
send_email! if email_enabled?
rescue ActiveRecord::RecordInvalid
# rubocop:disable Style/RedundantReturn
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be replaced with nil

@Gargron Gargron merged commit 8972e5f into master Sep 1, 2020
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-0.88.0 branch September 1, 2020 01:04
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 6, 2020
* Bump rubocop from 0.86.0 to 0.88.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.86.0...v0.88.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Fix for latest RuboCop

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yamagishi Kazutoshi <[email protected]>
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
* Bump rubocop from 0.86.0 to 0.88.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.86.0...v0.88.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Fix for latest RuboCop

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yamagishi Kazutoshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants