update Node to 6.x LTS #1228
Merged
update Node to 6.x LTS #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great call. |
krainboltgreene
added
breaking
|
Need to make sure everything works with the breaking changes from 4 -> 6. I'm pretty sure it'll be fine. |
|
Dunno why Travis' |
Gargron
reviewed
Apr 8, 2017
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 6.7.0 | |||
| lts/boron | |||
There was a problem hiding this comment.
Perhaps it expects a number version? Travis version of nvm could be different from yours.. I have not really used nvm before either, so I am not sure.
.travis.yml
Outdated
| @@ -28,7 +26,7 @@ before_install: | |||
| - sudo apt-get -qq update | |||
| - sudo apt-get -qq install g++-4.8 | |||
| install: | |||
| - nvm install $TRAVIS_NODE_VERSION | |||
| - nvm install | |||
| - npm install -g npm@3 | |||
There was a problem hiding this comment.
If Node 6+ comes with npm >=3, this line can be removed
dunn
force-pushed
the
node-version
branch
2 times, most recently
from
ac94609 to
fd8dc07
Compare
The 4.x branch [entered maintenance](https://github.com/nodejs/LTS#lts-schedule1) on 1 April.
|
The Travis people replied; with |
Gargron
approved these changes
Apr 15, 2017
Nyoho
referenced
this pull request
in Nyoho/mathtodon
Apr 25, 2017
The 4.x branch [entered maintenance](https://github.com/nodejs/LTS#lts-schedule1) on 1 April.
hannahwhy
pushed a commit
to hannahwhy/mastodon
that referenced
this pull request
Oct 5, 2019
Merge upstream changes
dariusk
added a commit
to friendcamp/mastodon
that referenced
this pull request
Dec 2, 2022
…icles Make the "media gallery" not show up on Articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4.x branch entered maintenance on 1 April.