improvement: allow <script src/> in html #2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
koaning
reviewed
Nov 22, 2024
|
|
||
| const replaceSrcScripts = (domNode: DOMNode): JSX.Element | undefined => { | ||
| if (domNode instanceof Element && domNode.name === "script") { | ||
| // Missing src, we don't handle inline scripts |
Contributor
There was a problem hiding this comment.
Technically, I guess I might want to add inline scripts in mohtml at some point? Maybe via alpine.js or surreal.js. That way you can easily use it to build custom components for Python classes.
Contributor
Author
There was a problem hiding this comment.
Maybe, its not hard to add, but tempted to just hold off and see why people need it, if people do, this is the change
const replaceSrcScripts = (domNode: DOMNode): JSX.Element | undefined => {
if (domNode instanceof Element && domNode.name === "script") {
const { src, ...attrs } = domNode.attribs;
// Handle inline scripts
if (!src) {
const script = document.createElement("script");
// Set any additional attributes
Object.entries(attrs).forEach(([key, value]) => {
script.setAttribute(key, value);
});
// Set content if any exists
if (domNode.children?.[0]?.data) {
script.textContent = domNode.children[0].data;
}
document.head.append(script);
return <></>;
}
// Handle src scripts
if (!document.querySelector(`script[src="${src}"]`)) {
const script = document.createElement("script");
script.src = src;
// Set any additional attributes
Object.entries(attrs).forEach(([key, value]) => {
script.setAttribute(key, value);
});
document.head.append(script);
}
return <></>;
}
};
akshayka
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
<script src/>tags to be properly created. This doesn't open up a new attack vector since this is already possible today with anywidget (running javascript)cc @koaning