Skip to content

Conversation

@koaning
Copy link
Contributor

@koaning koaning commented Nov 22, 2024

📝 Summary

Totally a minor update this one. This PR changes a pip install -e .[dev] into pip install -e ".[dev]" command in the Makefile.

🔍 Description of Changes

The reason I did this is because some shells (Zshell mainly, but maybe others too) seem to have trouble parsing the command in the Makefile. Gives me this error:

zsh: no matches found: .[dev]

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:37pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:37pm

@mscolnick mscolnick merged commit 5240322 into marimo-team:main Nov 22, 2024
19 checks passed
@koaning koaning deleted the patch-2 branch November 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants