Migrate from setup.py to Poetry pyproject.toml for packaging and environment management
#57
+1,129
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltondp
reviewed
Dec 10, 2024
Co-authored-by: Faisal Alquaddoomi <[email protected]>
Co-authored-by: Faisal Alquaddoomi <[email protected]>
falquaddoomi
approved these changes
Dec 11, 2024
|
Thank you @miltondp and @falquaddoomi for your reviews! Merging this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from a
setup.pyfile to a Poetry-flavorpyproject.tomlfile for packaging and environment management of this project. I've also added apre-commitcheck which ensures thepyproject.tomlfile andpoetry.lockfile are in good form for possible changes as things grow with this package.As part of this effort I also added https://github.com/rhysd/actionlint, https://github.com/tox-dev/pyproject-fmt, https://github.com/python-poetry/poetry (
poetry-check)pre-commitchecks to help ensure the work is well prepared and keeps consistent over time.Thanks for any feedback you may have!
Depends on and should be merged after #55
Addresses the first step of #52