Add get_doi_csl_item_zotero functionality #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
commented
Oct 25, 2019
| doi_retrievers = [ | ||
| get_doi_csl_item_crosscite, | ||
| get_doi_csl_item_zotero, | ||
| ] |
There was a problem hiding this comment.
Switching the order such that get_doi_csl_item_zotero is first would resolve #158. But in other cases, like for a bioRxiv preprint, the zotero metadata seems to be worse than what we get from crosscite (DOI Content Negotiation).
agitter
reviewed
Nov 15, 2019
|
|
||
| def test_get_doi_csl_item_zotero(): | ||
| """ | ||
| As of 2019-10-25, DOI Content Negotiation (i.e. crosscite) encodes the consurtium |
There was a problem hiding this comment.
I'm reviewing old pull requests I missed originally. There's a typo there that could be cleaned up later: consurtium -> consortium
agitter
reviewed
Nov 15, 2019
| def get_csl_item(identifier: str): | ||
| """ | ||
| Use a translation-server serach query followed by an export query | ||
| to return a CSL Item (the first & only record of a the returned CSL JSON). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.