Remove Pre-Roll-Logic from StrategyImpl #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=============================================
Coverage 86.01896% 86.01896%
=============================================
Files 44 44
Lines 844 844
Branches 116 116
=============================================
Hits 726 726
Misses 118 118
Continue to review full report at Codecov.
|
|
That makes sense. I can't merge this in until that gate is put in place though. |
|
Which gate are you talking about? |
|
Don't mind me. Brain farted. Merging now. |
notVitaliy
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As its a un-needed complexity in a Strategy implementation i would prefer to remove the preroll logic from those.
As its only preventing the signal, i would just move it as gate to the signal publish.
Due this this logic is completely hidden for a strategy, which should not care for those internal logics.