[mini_zip][build] Add minizip build target #835
Conversation
This change adds a build target for minizip_bin in the CMake build system.
|
@madler when you got some spare time, would you mind to check this one? |
|
Since I noticed that minizip was added to the prime Makefile (2bcc748). |
CMakeLists.txt
Outdated
| @@ -211,3 +211,12 @@ if(HAVE_OFF64_T) | |||
| target_link_libraries(minigzip64 zlib) | |||
| set_target_properties(minigzip64 PROPERTIES COMPILE_FLAGS "-D_FILE_OFFSET_BITS=64") | |||
| endif() | |||
|
|
|||
| #============================================================================ | |||
| # Minigzip tool | |||
| # Minizip tool | ||
| #============================================================================ | ||
| add_executable(minizip_bin contrib/minizip/minizip.c contrib/minizip/ioapi.c | ||
| contrib/minizip/ioapi.h contrib/minizip/unzip.c |
There was a problem hiding this comment.
missing iowin32.[ch] for Windows build
There was a problem hiding this comment.
Agreed, I will setup a Windows box to test.
|
@gvollant: Can you look? |
|
Thanks, but I don't want to add a minizip build to the main CMakeLists.txt. The contrib stuff should stay distinct from zlib. If someone wanted to add a CMakeLists.txt to contrib/minizip, that would be fine. (The minizip-test target in the main Makefile is just there for my use for testing purposes. Not to provide a build of minizip. That's what the Makefile in contrib/minizip is for.) |
|
@Adenilson, @bahaa-cpl: @AndrewAtAvenza has created a ticket here: Linked to: |
superseeds madler#835
This change adds a build target for minizip_bin in the CMake build system.