Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused sys/types.h cmake configuration. #432

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove unused sys/types.h cmake configuration. #432

wants to merge 1 commit into from

Conversation

jaykrell
Copy link

No description provided.

@WildCard65
Copy link

Necroing this, but it appears that cmake will check for sys/types.h no matter what.

nmoinvaz
nmoinvaz approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@nmoinvaz nmoinvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also noticed this in zlib-ng and removed it.

Vollstrecker pushed a commit to cmake-remake/zlib that referenced this pull request Dec 1, 2024
remove checks for sys/types.h, stdint.h and stddef.h as this is done …
c6b9b63 
…by check_type_size anyways

superseeds madler#432
@Vollstrecker Vollstrecker mentioned this pull request Dec 11, 2024
Open
@Neustradamus Neustradamus mentioned this pull request Jan 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaykrell @WildCard65 @nmoinvaz