Mac OS X linker does not support --version-script #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OS X's linker is derived from LLVM, not GNU binutils, and it does not support
--version-script
.This commit disables that option for
APPLE
. There are some possible problems with this:APPLE
for all versions of Mac OS. I have no idea what toolchains exist on Mac OS 9 or earlier, so I have no way of knowing if this is correct.--version-script
, there's nothing to restrict which symbols are visible in the resulting libraries.I don't know if either of these are important. That said, I do know that Mac OS X is broken with both the current release and the current master:
It builds with this change.