CMake: use CMAKE_CURRENT_SOURCE_DIR, *not* top-level src dir. Fixes #218 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LebedevRI
changed the title
|
Ping :) |
|
Can we merge this? I think this is a pretty clear fix for #218 (which I'm pretty sure is an actual bug). |
msftphil
pushed a commit
to microsoft/msix-packaging
that referenced
this pull request
Feb 28, 2018
A bug on the CMakeLists.txt file that zlib provides makes zlib fail to compile when is used via add_subdirectory() by another project. For some reason, this issue only happens for Linux. There's an already existing open PR since Feb 2017 with the fix (madler/zlib#219). This PR changes the zlib submodule to point to that commit.
|
Any news? |
|
@madler can you please advise how to proceed to get this PR merged? The fix has been available for >1 year, it's a trivial change and multiple users have expressed the interest in having this fixed in the discussion. I would be great to see this fixed in the upstream. |
|
@madler ping? |
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #218.
I suspect this also fixes #132