Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt fixes for linux #15

Closed
wants to merge 2 commits into from
Closed

CMakeLists.txt fixes for linux #15

wants to merge 2 commits into from

Conversation

qtip
Copy link
Contributor

@qtip qtip commented Apr 3, 2012

When I tried to add zlib as an external project on linux like so:

ExternalProject_add( zlib
    GIT_REPOSITORY git://github.com/madler/zlib.git
    GIT_TAG develop
    CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_CURRENT_BINARY_DIR}/zlib-install
)

I got a couple of errors which I've fixed in this pull request.

#define ZLIB_VERSION "1.2.7-motley"

wasn't getting parsed correctly with the current regex.

Also,

-Wl,--version-script,zlib.map

wasn't finding zlib.map, which may have to do with it being an "external project".

@madler
Copy link
Owner

madler commented Apr 30, 2012

Merged, with comment.

@madler madler closed this Apr 30, 2012
geoff-nixon referenced this pull request in geoff-nixon/zlib May 6, 2016
@Dead2
Merge pull request cloudflare#15 from daxtens/cleanups
7f6dc8f 
Compile with -Wall -Werror
nmoinvaz pushed a commit to nmoinvaz/zlib that referenced this pull request May 2, 2020
@kentonv @vkrasnov
Don't disable target optimizations when cross-compiling. (madler#15)
ffda798 
* PS-237 Don't disable target optimizations when cross-compiling.

AFAICT there's no reason to check the host platform here. The test only runs the compiler; it doesn't execute the output.

* Add misc intermediate files to .gitignore.
jinfeihan57 pushed a commit to minchai23/zlib that referenced this pull request Sep 15, 2020
@kuba--
Zip entry open/fix 13 (madler#15)
c04da19 
* Internally replace '\' by '/' for entry name.

* Add tests
@Neustradamus Neustradamus mentioned this pull request Jan 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qtip @madler