Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comment that differ from current plugin implementation #927

Merged
merged 1 commit into from
Aug 10, 2023
Merged

remove comment that differ from current plugin implementation #927

merged 1 commit into from
Aug 10, 2023

Conversation

kga
Copy link
Member

@kga kga commented Aug 10, 2023

Currently, mackerel-plugin-redis supports password authentication. refs. mackerelio/mackerel-agent-plugins#232

yseto
yseto approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@yseto yseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.

@yseto yseto merged commit 23d2279 into master Aug 10, 2023
@yseto yseto deleted the remove-plugin-redis-comment branch August 10, 2023 05:57
@mackerelbot mackerelbot mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yseto yseto yseto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kga @yseto