Pass -fno-sanitize-recover=all to make all UBSan detections fatal #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
force-pushed
the
no-sanitize-recover
branch
from
b0b3802
to
5eae547
Compare
From the clang docs: > By default, non-fatal checks are those enabled by UndefinedBehaviorSanitizer, except for -fsanitize=return and -fsanitize=unreachable.
squeek502
force-pushed
the
no-sanitize-recover
branch
from
5eae547
to
dfc1475
Compare
This was doing pointer addition where i could be >= LUV_THREAD_MAXNUM_ARG and then subtracting afterwards. By doing the subtraction first, the number is properly bounded within 0..LUV_THREAD_MAXNUM_ARG
squeek502
force-pushed
the
no-sanitize-recover
branch
from
bb44a8c
to
4d56378
Compare
zhaozg
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the clang docs:
Closes #697