thread_setaffinity: Allow affinity param to have a length less than cpumask_size()
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pumask_size()
Instead of enforcing that the table length is >= cpumask_size(), any missing CPU numbers get assigned an affinity of `false`. This makes this API a bit more user-friendly, since users no longer have to initialize a table of length `cpumask_size()` before setting the particular affinities they actually want.
As an example, before this commit, you'd have to do something like:
local affinity = {}
for i=1,uv.cpumask_size() do
affinity[i] = false
end
affinity[3] = true
affinity[5] = true
But after this commit, this table:
local affinity = { [3] = true, [5] = true }
will now be accepted and all the missing keys up to `uv_cpumask_size()` will be treated as `false` in the `thread_setaffinity` call.
|
I can't see your comments |
|
Mainly because lua_rawlen of a table(not array) will return 0. From 415 line int min_mask_size = uv_cpumask_size();
if (min_mask_size < 0) {
return luv_error(L, min_mask_size);
}
int mask_size = lua_rawlen(L, 2);
if (mask_size < min_mask_size) {
mask_size = min_mask_size;
}
char* cpumask = malloc(mask_size);can be simplify to int mask_size = uv_cpumask_size();
if (mask_size < 0) {
return luv_error(L, mask_size);
}
char* cpumask = malloc(mask_size); |
zhaozg
approved these changes
May 23, 2023
squeek502
force-pushed
the
user-friendly-setaffinity
branch
from
bd82284
to
53f5cba
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of enforcing that the table length is
>= cpumask_size(), any missing CPU numbers get assigned an affinity offalse. This makes this API a bit more user-friendly, since users no longer have to initialize a table of lengthcpumask_size()before setting the particular affinities they actually want.As an example, before this commit, you'd have to do something like:
But after this commit, this table:
will now be accepted and all the missing keys up to
uv_cpumask_size()will be treated asfalsein thethread_setaffinitycall.