Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak from fs_scandir whenever it wasn't fully iterated via fs_scandir_next #601

Merged
merged 1 commit into from
May 31, 2022

Commits on May 31, 2022

  1. Fix leak from fs_scandir whenever it wasn't fully iterated via `fs_…

    …scandir_next`
    
    Now, we have a specialized metatable ("uv_fs") with a gc function that's only used for scandir's uv_fs_t reqs, so that it will always be cleaned up automatically. This also means that once fully iterated, the req is no longer immediately cleaned up and so any subsequent calls to `fs_scandir_next` will just return `nil` (whereas previously it would have errored out in `luv_check_fs`).
    
    Closes luvit#600
    squeek502 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    35b0042 View commit details
    Browse the repository at this point in the history