This repository has been archived by the owner on May 18, 2020. It is now read-only.
New npm module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommmyy
reviewed
Jan 26, 2018
.editorconfig
Outdated
| @@ -0,0 +1,11 @@ | |||
| # http://editorconfig.org | |||
README.md
Outdated
| @@ -1,3 +1,104 @@ | |||
| # redux-extensible-store | |||
|
|
|||
| Redux extension that allows you to dynamickly inject new reducers and sagas into you running application. | |||
README.md
Outdated
|
|
||
| ## Why? | ||
|
|
||
| If you are using dynamic imports or some kind of a code splitting then you probably need to register new reducers and sagas the time your JS chunk is loaded. So what does this module provides? We call these ad-hoc loaded modules a widgets. |
| @@ -0,0 +1,26 @@ | |||
| import babel from 'rollup-plugin-babel'; | |||
There was a problem hiding this comment.
Mrkni na rollup.config v react-union, generuje se tam ještě ecmascript build
.editorconfig
Outdated
| @@ -0,0 +1,11 @@ | |||
| # http://editorconfig.org | |||
There was a problem hiding this comment.
prosím, sjednotit s react-union
README.md
Outdated
| @@ -1,3 +1,104 @@ | |||
| # redux-extensible-store | |||
|
|
|||
| Redux extension that allows you to dynamickly inject new reducers and sagas into you running application. | |||
README.md
Outdated
|
|
||
| ## Why? | ||
|
|
||
| If you are using dynamic imports or some kind of a code splitting then you probably need to register new reducers and sagas the time your JS chunk is loaded. So what does this module provides? We call these ad-hoc loaded modules a widgets. |
| @@ -0,0 +1,59 @@ | |||
| { | |||
There was a problem hiding this comment.
chybí contributor, keywords a "es" entry point
| import invariant from 'invariant'; | ||
| import injectionMiddleware from './injectionMiddleware'; | ||
|
|
||
| const createReducers = asyncReducers => |
There was a problem hiding this comment.
Tome, asi se na mě naštveš, ale me ten zápis ze snipetu příjde méně přehledný :(
src/extensibleStore.js
Outdated
| const cancelSaga = key => { | ||
| if (!isNil(store.injectedSagas[key])) { | ||
| store.injectedSagas[key].task.cancel(); | ||
| store.injectedSagas[key] = null; |
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.