-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix new search issues #10584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new search issues #10584
Conversation
tiensonqin
commented
Nov 30, 2023
•
edited
Loading
edited
- Fixes [New Search] Search results contains hidden system properties #10573
- Fixes [New Search] Search results (page names) are lowercased #10574
- Fixes [New Search] Commands shortcuts are hidden by default #10575
- Fixes [New Search] Deleted page still visible in search results #10576
- Fixes [New Search] Search modal window left open after selecting some search result #10577
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiensonqin Tested all the fixes and they work great! 🐛 ⚡ I'm not sure if removing deleted pages from Recents is improved ux. It may confuse users if they rely on Recents as unmodified history
@logseq-cldwalker Maybe we can leave the deleted pages in Recents and show a message like "This page has been deleted, do you want to create a new one or remove it from Recents?". I'm going to merge this PR, we can improve this later with more feedback. |
803db73
to
ad0196a
Compare
The nice idea of Recents was like it were before New Search: Recents is a search terms. And selecting the search term leads to input it to query filed, not to opening a page.
|