fix #9506: close history panel after select a version #10530
Conversation
|
Thanks for the fix.
For a temp fix of #9506, press CC @xyhp915 The file version list and file-specific-version modal should be merged into one. |
I am willing to try to merge the version list and file-specific-version modal to one modal. Is it ok to submit my solution in this PR? |
So appreciate that! |
Ok, I will try to submit my solution to this PR |
|
Here is how the version select works after e876a15 logseq-pr-1.mp4 |
CNLHC
changed the title
CNLHC
changed the title
|
BTW，I proposed a new feature request (a diff view) in the forum which is related to this PR. |
CNLHC
force-pushed
the
feat/close-notifications-after-select-version
branch
from
c038711 to
0b762cd
Compare
CNLHC
force-pushed
the
feat/close-notifications-after-select-version
branch
from
0b762cd to
c2a371c
Compare
tiensonqin
force-pushed
the
feat/close-notifications-after-select-version
branch
from
955637a to
483f477
Compare
|
@CNLHC I'll handle the remaining fix to get it merged. |
andelf
force-pushed
the
feat/close-notifications-after-select-version
branch
from
be23411 to
38621a4
Compare
andelf
force-pushed
the
feat/close-notifications-after-select-version
branch
from
38621a4 to
fa48f37
Compare
This PR is a quick fix to #9506
Since the version list (which is a notification panel) is currently overlapped with the versioned file content (which is a modal), I think the most straightforward way to fix this problem is to close the notification panel after the user open the file content modal.