Further IIS parsing improvements#4921
Open
pyllyukko wants to merge 1 commit intolog2timeline:mainfrom
Open
Conversation
Member
|
@pyllyukko thanks for flagging, I'll take a closer look when time permits.
this looks like IIS handling Unicode characters in a non-URI safe manner, adding individual characters is going to be a whack-a-mole approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran a few scanners against vanilla IIS running in Windows Server 2022 and made sure everything parses.
Details:
Iteration 1
Add
*to_URI_SAFE_CHARACTERS.Iteration 2
Add
~to_URI_SAFE_CHARACTERS.Iteration 3
Add
|to_URI_SAFE_CHARACTERS.Iteration 4
Request:
[]<>{}$to_URI_SAFE_CHARACTERS[]from_UA$from_URI_STEM{}from_COOKIE{}|,~[],<>&$from_QUERYIteration 5
Request:
\'to_URI_SAFE_CHARACTERS\'from_QUERYIteration 6
"to_URI_SAFE_CHARACTERS"from_COOKIE"from_QUERYIteration 7
Added
!to_URI_SAFE_CHARACTERSIteration 8
Request:
_URI_SAFE_CHARACTERS_QUERY#to_URI_SAFE_CHARACTERSIteration 9
Request:
Added
À¯to_URI_SAFE_CHARACTERSIteration 10
Added
çto_URI_SAFE_CHARACTERSIteration 11
Added
¡to_URI_SAFE_CHARACTERSIteration 12
Request:
@\\to_UAIteration 13
Request:
@\\to_URI_SAFE_CHARACTERS_UA,_COOKIE&_QUERYEverything parses now.