Chrome cache payloads #4696
Open
Chrome cache payloads #4696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
- Coverage 86.12% 86.01% -0.12%
==========================================
Files 416 416
Lines 37446 37344 -102
==========================================
- Hits 32252 32123 -129
- Misses 5194 5221 +27
☔ View full report in Codecov by Sentry. |
|
@chb2mn must have missed this earlier, looks like this PR has a merge conflict |
joachimmetz
force-pushed
the
chrome_cache_payloads
branch
from
7a19acc to
d708c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Chrome:cache:entry events only consist of url + time. I wanted to add some richness to that
Description:
I wanted to include some information about the actual payload in the cache. So this includes human-readable information about the datastream(s) behind an entry. The data streams are either internal (
data_N (offset: 0x123456)) or external (f_012345).Notes:
@joachimmetz I wanted your opinion on how to format the payload. Right now it's just a
json.dumps(my_list), but there's probably a more elegant way of adding the info to the event.Checklist: