Open
Conversation
Member
|
@caeaguilar thx for the proposed PR, this must have slipped my attention earlier. Having a closer look when time permits, will leave some initial feedback. |
Member
|
You'll need to update https://github.com/log2timeline/plaso/blob/main/data/timeliner.yaml as well |
joachimmetz
reviewed
Feb 8, 2023
| message: | ||
| - 'loglevel: {loglevel}' | ||
| - 'recorded_time: {recorded_time}' | ||
| - 'appname: {appname}' |
Member
There was a problem hiding this comment.
don't use abbreviations as per style guide https://github.com/log2timeline/l2tdocs/blob/main/process/Style-guide.md
joachimmetz
reviewed
Feb 8, 2023
| - 'Message: {message}' | ||
| short_source: 'LOG' | ||
| source: 'AnyDesk Ad Trace Log' | ||
|
|
Member
There was a problem hiding this comment.
change to --- to signify new definition
joachimmetz
reviewed
Feb 8, 2023
| """Imports for the text parser.""" | ||
|
|
||
| from plaso.parsers.text_plugins import android_logcat | ||
| from plaso.parsers.text_plugins import anydesk_adtrace |
Member
There was a problem hiding this comment.
nit: use alphabetical ordering
Member
|
You'll need to add a test and test data as well |
joachimmetz
added
the
pending reporter input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Added text parser plugin for AnyDesk Activity Log (ad.trace)
Description:
Parse and generates event data for each line in the ad.trace log file generated by AnyDesk client/server
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: