Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nomination] Add an extra Red Hat representative to the security group #92174

Merged
merged 1 commit into from
May 29, 2024

Conversation

tuliom
Copy link
Contributor

@tuliom tuliom commented May 14, 2024

I'd like to nominate myself as another Red Hat representative. I work at the LLVM team at Red Hat contributing to upstream and downstream.

I'd like to nominate myself as another Red Hat representative.
I work at the LLVM team at Red Hat contributing to upstream and
downstream.
@tuliom
Copy link
Contributor Author

tuliom commented May 21, 2024

@ahmedbougacha , @andykaylor , @mrragava , @DimitryAndric , @emaste , @gburgessiv , @kbeyls , @mmdriley , @ojhunt , @pogo59 , @smithp35 , @pietroalbini , @serge-sans-paille , @GreatKeeper , @wphuhn-intel , Could you take a look at this PR, please?

@cuviper I'm not sure you can review this nomination as we both work at Red Hat. Anyway, I'm pinging you too for awareness.

Copy link
Collaborator

@pogo59 pogo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DimitryAndric
Copy link
Collaborator

I think it would be better if somebody from Red Hat who is already on this list introduced you... Who knows, maybe you are now social-engineering yourself into this group? :)

Copy link
Member

@gburgessiv gburgessiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who knows, maybe you are now social-engineering yourself into this group? :)

Seems like a bold strategy, but I agree with the sentiment given that it's trivial for another RH member member to ack this.

I count @cuviper's thumbs-up on the PR as an ack, so LGTM

Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make my ack more explicit. :)

I know Tulio in his role in the LLVM team at Red Hat, and I vouch for him to join this group.

Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrragava
Copy link
Contributor

LGTM

@tuliom
Copy link
Contributor Author

tuliom commented May 28, 2024

Thanks for all the reviews and approvals.
May I merge this PR myself or should I wait for a current member to do this?

@kbeyls
Copy link
Collaborator

kbeyls commented May 29, 2024

Thanks for all the reviews and approvals. May I merge this PR myself or should I wait for a current member to do this?

As per https://llvm.org/docs/Security.html#choosing-new-members, I was waiting for "5 business days" since "a majority of existing LLVM Security Group members" supports the the nomination.
If I calculated correctly, these 5 business days have just passed, so I'll go ahead and merge this PR.

@kbeyls kbeyls merged commit a72a906 into llvm:main May 29, 2024
6 checks passed
vg0204 pushed a commit to vg0204/llvm-project that referenced this pull request May 29, 2024
llvm#92174)

I'd like to nominate myself as another Red Hat representative. I work at
the LLVM team at Red Hat contributing to upstream and downstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.