Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InstCombine] samesign flag should be dropped #112356

Closed
dtcxzyw opened this issue Oct 15, 2024 · 0 comments · Fixed by #112358
Closed

[InstCombine] samesign flag should be dropped #112356

dtcxzyw opened this issue Oct 15, 2024 · 0 comments · Fixed by #112358
Assignees
@dtcxzyw
Labels
llvm:ir miscompilation

Comments

@dtcxzyw
Copy link
Member

dtcxzyw commented Oct 15, 2024

Reproducer:

define i1 @src(i32 %In) {
  %c1 = icmp samesign sgt i32 %In, -1
  %c2 = icmp samesign eq i32 %In, 1
  %V = select i1 %c1, i1 %c2, i1 false
  ret i1 %V
}

define i1 @tgt(i32 %In) {
  %c2 = icmp samesign eq i32 %In, 1
  ret i1 %c2
}

We should check this flag in Operator::hasPoisonGeneratingFlags.
@dtcxzyw dtcxzyw self-assigned this Oct 15, 2024
@dtcxzyw dtcxzyw mentioned this issue Oct 15, 2024
Merged
dtcxzyw added a commit that referenced this issue Oct 15, 2024
@dtcxzyw
[IR] Add support for samesign in `Operator::hasPoisonGeneratingFlag…
9b7491e 
…s` (#112358)

Fix #112356.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this issue Oct 16, 2024
@dtcxzyw @bricknerb
[IR] Add support for samesign in `Operator::hasPoisonGeneratingFlag…
31e6dd1 
…s` (llvm#112358)

Fix llvm#112356.
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this issue Oct 16, 2024
@dtcxzyw @DanielCChen
[IR] Add support for samesign in `Operator::hasPoisonGeneratingFlag…
e870846 
…s` (llvm#112358)

Fix llvm#112356.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this issue Oct 17, 2024
@dtcxzyw @bricknerb
[IR] Add support for samesign in `Operator::hasPoisonGeneratingFlag…
7ea11c6 
…s` (llvm#112358)

Fix llvm#112356.
EricWF pushed a commit to efcs/llvm-project that referenced this issue Oct 22, 2024
@dtcxzyw @EricWF
[IR] Add support for samesign in `Operator::hasPoisonGeneratingFlag…
2ea4e43 
…s` (llvm#112358)

Fix llvm#112356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtcxzyw dtcxzyw

Labels
llvm:ir miscompilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IR] Add support for samesign in Operator::hasPoisonGeneratingFlags dtcxzyw/llvm-project
1 participant
@dtcxzyw