Added stub method in to handle duplicates in sub-commands DAT-19049 #6558
+91
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,6 +189,15 @@ public SortedSet<CommandDefinition> getCommands(boolean includeInternal) { | |||
| return Collections.unmodifiableSortedSet(commands); | |||
|
|
|||
| } | |||
| private static String findKeyInMapIgnoreCase(String key, Map<String, String[]> map) { | |||
There was a problem hiding this comment.
What is the idea behind this findKeyInMapIgnoreCase ?
DAT-19049
DAT-19049
filipelautert
approved these changes
Dec 4, 2024
obovsunivskyii
temporarily deployed
to
internal
GitHub Actions
Inactive
obovsunivskyii
temporarily deployed
to
internal
GitHub Actions
Inactive
obovsunivskyii
temporarily deployed
to
internal
GitHub Actions
Inactive
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
* [DAT-18890] Implement copy method in FilesystemProjectCopier, change visibility in InitCopyCommandStep. * [DAT-18890] Enhance error message * [DAT-18890] Copy files using copyLarge. Format file.
…cognized as stubs (#6328) * Added a stub attribute to CommandStep interface DAT-18431 * Refactored to support stub commands DAT-18431 * Refactored code to avoid duplication DAT-18431
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows commands to mark themselves as "stubs", which can be implemented to handle situations where an extension that provides the command does not exist. Unfortunately, we have to do this because Pico does not allow duplicate sub-commands.
Impact
Description
Things to be aware of
Things to worry about
Additional Context