Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert simple constant to the SQL for projection. #4564

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

sdanyliv
Copy link
Member

Fixes #4559

@sdanyliv
Copy link
Member Author

/azp run test-all

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdanyliv
Copy link
Member Author

/azp run test-all

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 9ca3b4a, reversing
changes made to d917401.
@sdanyliv
Copy link
Member Author

/azp run test-all

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

@igor-tkachev
Copy link
Member

Does it support method Sql.AsSql? It should generate SQL if it's used.

@sdanyliv
Copy link
Member Author

@igor-tkachev, sure Sql.AsSql will force constant conversion to the SQL.

@MaceWindu MaceWindu merged commit 3e69ec9 into master Jul 13, 2024
65 of 67 checks passed
@MaceWindu MaceWindu deleted the issue/4559 branch July 13, 2024 12:15
MaceWindu pushed a commit to linq2db/linq2db.baselines that referenced this pull request Jul 13, 2024
* [Windows / SQL Server EXTRAS] baselines

* [Linux / Firebird 2.5] baselines

* [Linux / SQL Server 2019] baselines

---------

Co-authored-by: Azure Pipelines Bot <[email protected]>
@MaceWindu MaceWindu added this to the 6.0.0-preview.2 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Firebird 2.5 provider could emit unnecessary '1' (true) constant column
5 participants