Fix non-lazy conditional evaluation #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
… parsing steps to improve simple queries parsing speed.
# Conflicts: # Source/LinqToDB/Linq/Builder/ParametersContext.cs
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdanyliv
requested review from
igor-tkachev,
sdanyliv,
viceroypenguin,
jods4 and
Shane32
as code owners
viceroypenguin
previously approved these changes
Jun 28, 2024
Source/LinqToDB/DataProvider/Informix/InformixSqlExpressionConvertVisitor.cs
Outdated
Show resolved
Hide resolved
Source/LinqToDB/DataProvider/Informix/InformixSqlExpressionConvertVisitor.cs
Outdated
Show resolved
Hide resolved
Comment on lines
928
to
+932
| if (e.Method == null && (e.IsLifted || e.Type == typeof(object))) | ||
| return placeholder; | ||
|
|
||
| if (e.Method == null && operandExpr is not SqlPlaceholderExpression) | ||
| return e; |
There was a problem hiding this comment.
would prefer to group these two checks as sub-checks of a single if (e.Method is null)
Closed
Co-authored-by: Stuart Turner <[email protected]>
Co-authored-by: Stuart Turner <[email protected]>
Co-authored-by: Stuart Turner <[email protected]>
…q2db/linq2db into issue/conditional-evaluation
|
/azp run test-informix |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
viceroypenguin
approved these changes
Jun 28, 2024
MaceWindu
pushed a commit
to linq2db/linq2db.baselines
that referenced
this pull request
Jun 29, 2024
* [Windows / SQLite (both providers)] baselines * [Windows / SQL CE] baselines * [Windows / Access MDB (Jet/ODBC)] baselines * [Windows / SQLite (specialized tests)] baselines * [Windows / SQL Server 2019] baselines * [Windows / SQL Server 2014] baselines * [Windows / SQL Server 2016] baselines * [Windows / SQL Server EXTRAS] baselines * [Linux / DB2 LUW 11.5] baselines * [Windows / SQL Server 2008] baselines * [Linux / Firebird 2.5] baselines * [Windows / SQL Server 2017] baselines * [Linux / Firebird 3.0] baselines * [Linux / Informix 14.10] baselines * [Linux / MariaDB 11] baselines * [Linux / Firebird 5.0] baselines * [Linux / ClickHouse MySql] baselines * [Linux / ClickHouse Client] baselines * [Linux / Firebird 4.0] baselines * [Linux / MySQL 8 (both providers)] baselines * [Linux / MySQL 5.7 (both providers)] baselines * [Linux / PostgreSQL 12] baselines * [Linux / PostgreSQL 13] baselines * [Linux / Oracle 11g XE] baselines * [Windows / SQL Server 2022] baselines * [Linux / PostgreSQL 11] baselines * [Linux / Oracle 12c] baselines * [Linux / PostgreSQL 15] baselines * [Linux / PostgreSQL 14] baselines * [Linux / Oracle 21c] baselines * [Linux / Oracle 19c] baselines * [Linux / PostgreSQL 16] baselines * [Linux / Oracle 23c] baselines * [Linux / Oracle 18c] baselines * [Linux / Sybase ASE 16] baselines * [Linux / ClickHouse Octonica] baselines * [Linux / SQL Server 2019] baselines * [Windows / Access MDB (Jet/ODBC)] baselines * [Windows / SQL Server 2005] baselines * [Windows / SQL Server EXTRAS] baselines * [Windows / SQL Server 2012] baselines * [Windows / Access MDB (Jet/ODBC)] baselines * [Windows / SQL Server 2005] baselines * [Linux / SQL Server 2019] baselines * [Linux / SAP HANA 2] baselines --------- Co-authored-by: Azure Pipelines Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.