feat: open source the event generator gradle plugin #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealChrisL
reviewed
Dec 8, 2020
...b/src/main/java/com/linkedin/metadata/annotations/DefaultGmaEntitiesAnnotationAllowList.java
Outdated
Show resolved
Hide resolved
|
|
||
| ## What are "v5" Metadata Events? | ||
|
|
||
| In brief, we've split the monolithic MCE/MAE/FMCE events into smaller events. One event per aspect-entity combination. |
There was a problem hiding this comment.
use the order of entity-aspect?
There was a problem hiding this comment.
Any particular reason why?
There was a problem hiding this comment.
because we break down the event in the order of form? namespace com.linkedin.mxe.corpUser.corpUserInfo
There was a problem hiding this comment.
The text here isn't meant to indicate order, just the pairing. If you feel it is important to be consistent we can change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin exists internally and I am now open sourcing it.
I've added two commits to this PR to make reviewing easier. The second is new documentation that should be thoroughly reviewed; while the code changes could perhaps be more skimmed over since they already exist internally.
Checklist