fix(backfill): update a_urn column during entity table backfill #491
Conversation
| private static final String SQL_UPSERT_ASPECT_WITH_URN_TEMPLATE = | ||
| "INSERT INTO %s (urn, a_urn, %s, lastmodifiedon, lastmodifiedby) VALUE (:urn, :a_urn, :metadata, :lastmodifiedon, :lastmodifiedby) " | ||
| + "ON DUPLICATE KEY UPDATE %s = :metadata, lastmodifiedon = :lastmodifiedon;"; | ||
| + "ON DUPLICATE KEY UPDATE %s = :metadata, lastmodifiedon = :lastmodifiedon, a_urn = :a_urn;"; |
There was a problem hiding this comment.
would this logic only be called when a_urn column presents? how to ensure this or can you clarify in the comment a_urn always exists when this is called and why?
There was a problem hiding this comment.
Basically yes, there is a flag that is passed into all of the SQL statement methods that indicates whether the a_urn column exists. If it does, then use template 1, if not, use template 2
| @@ -43,7 +43,7 @@ public void testCreateUpsertAspectSql() { | |||
| String expectedSql = | |||
| "INSERT INTO metadata_entity_foo (urn, a_urn, a_aspectfoo, lastmodifiedon, lastmodifiedby) VALUE (:urn, " | |||
| + ":a_urn, :metadata, :lastmodifiedon, :lastmodifiedby) ON DUPLICATE KEY UPDATE a_aspectfoo = :metadata," | |||
| + " lastmodifiedon = :lastmodifiedon;"; | |||
| + " lastmodifiedon = :lastmodifiedon, a_urn = :a_urn;"; | |||
There was a problem hiding this comment.
do we have similar unit test that covers entity without a_urn?
There was a problem hiding this comment.
It is right underneath. There is a flag passed into createUpsertAspectSql() which indicates if a_urn column exists or not. It is only controlled by the DAO code, not the user.
There was a problem hiding this comment.
sounds good, thanks for clarification.
Summary
Currently, backfillEntityTables API does not backfill the a_urn column. This is an oversight since we never expected to need to backfill this column and it cannot be backfilled like other aspect columns. Thus, the solution is to add it to the upsert SQL which is called in EbeanLocalAccess::add.
Testing Done
./gradlew build
Checklist