fix(new schema): fix duplicate key exception for aspect table #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhiagr
reviewed
Dec 18, 2024
| // table. Therefore, we will apply compare-and-set with oldTimestamp on entity table (addWithOptimisticLocking). | ||
| // We will also apply an optimistic locking update over (urn, aspect, version) primary key combination to avoid duplicate | ||
| // key exceptions when the primary key includes createdon. | ||
| EbeanMetadataAspect result = findLatestMetadataAspect(_server, urn, aspectClass); |
There was a problem hiding this comment.
What if the urn and aspect does not exist? What does this return?
rakhiagr
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In new schema mode, the aspect table is not getting update with optimistic locking on the createdon column. As a result, the duplicate version 0 rows in job-gms are causing duplicate key exceptions even in new schema mode.
To fix, read the latest row from the aspect table, get the timestamp, and also perform an update using the old timestamp to match a single row in the aspect table.
Testing Done
./gradlew build
Checklist