Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aim): make an exception for checkSameSourceUrn for AIM case #484

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jsdonn
Copy link
Contributor

@jsdonn jsdonn commented Dec 9, 2024

Summary

AIM integration tests are failing because of this validation check. They have a special case where the urn from which the relationship is derived (MlFeatureVersion) is the destination of the Produces relationship. Allow this use case temporarily while AIM redesigns their models.

Testing Done

mint build

Checklist

@jsdonn jsdonn marked this pull request as ready for review December 9, 2024 18:54
Copy link
Contributor

@ybz1013 ybz1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better with some constants and sets for the entities if this gets more.

But for now, approving to unblock user.

Copy link
Contributor

@sam-zen-dev sam-zen-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the quick change.

@jsdonn jsdonn merged commit ff330d3 into linkedin:master Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants