fix(dual schema): use aspect table as SOT for optimistic locking in DUAL_SCHEMA mode #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangyangv2
reviewed
Dec 9, 2024
| numOfUpdatedRows = runInTransactionWithRetry(() -> { | ||
| // Additionally, in DUAL_SCHEMA mode: apply a regular update (no optimistic locking) to the entity table | ||
| if (_schemaConfig == SchemaConfig.DUAL_SCHEMA) { | ||
| _localAccess.addWithOptimisticLocking(urn, (ASPECT) value, aspectClass, newAuditStamp, null, |
There was a problem hiding this comment.
is this conflict with the comment (no optimistic locking)?
There was a problem hiding this comment.
The comment is correct, we pass null oldTimestamp to the addWithOptimisticLocking function on the entity tables, which will just do a regular update because of null oldTimestamp
yangyangv2
reviewed
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, optimistic locking had the following behavior:
in NEW_SCHEMA and DUAL_SCHEMA modes:
getLatest from entity table
add with optimistic locking to aspect table using old timestamp from entity table
in OLD_SCHEMA mode:
getLatest from aspect table
add with optimistic locking to aspect table using old timestamp from aspect table
Now, use the aspect table when in DUAL_SCHEMA mode which makes sense since DUAL_SCHEMA mode will read from both tables but eventually return the result from the old schema table anyways.
Testing Done
update unit tests
Checklist